Fix some rescaling issues smoked out by the regional Bering domain #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove conflict with dev/emc
further resolve conflict
put id_sppt_wts, etc back.
* remove white space and fix comment * Update MOM_oda_incupd.F90 remove unused index bounds, and fix sum_h2 loop. Co-authored-by: pjpegion <Philip.Pegion@noaa.gov> Co-authored-by: Marshall Ward <marshall.ward@noaa.gov>
- Pointing to OBC wiki file from the lateral parameterizations doc. - Using the MOM6 verbosity to control the time_interp verbosity. - Making the check for negative water depths more informative.
- Scaling of OBC's dz_src. - Scaling of CS%IDatu in MOM_barotropic.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #104 +/- ##
=========================================
Coverage 28.76% 28.77%
=========================================
Files 248 248
Lines 72968 72985 +17
=========================================
+ Hits 20990 20998 +8
- Misses 51978 51987 +9
Continue to review full report at Codecov.
|
|
I just pushed a fix to the rest of your comments (thank you!) except for the MOM_lateral_boundary_diffusion one. It would require GV%m_to_H and GV%kg_m2_to_H to be passed through too. |
Added the new run-time parameter ODA_2018_ANSWERS to recover the answers from the previous version of the code, which did not supply properly dimensional rescaled minimum thicknesses for the remapping calls in the ODA driver. When this is set to True, all answers are bitwise identical.
Hallberg-NOAA
approved these changes
Apr 20, 2022
This was referenced May 16, 2022
marshallward
pushed a commit
that referenced
this pull request
Feb 8, 2023
update to MOM6 main 20220902 commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #54